Skip to content

fix(desktop): allow Neovim console access on older WSL - #48

Merged
kalvenschraut merged 1 commit into
rtvisionfrom
fix/neovim-wsl-console-access
Sep 11, 2026
Merged

kalvenschraut merged 1 commit into
rtvisionfrom
fix/neovim-wsl-console-access

Conversation

@kalvenschraut

@kalvenschraut kalvenschraut commented Sep 10, 2026 •

Copy link
Copy Markdown
Member

Opening Neovim through the Windows desktop app can fail before SSH starts with Wsl/Service/E_ACCESSDENIED on WSL 2.2.4. The standalone helper opens CONIN$ read-only; an otherwise identical helper with read/write access passed the affected machine's comparison test.

Open the interactive console handle with r+. PowerShell remains the outer launcher, and WSL distro/account selection, home-directory SSH credentials, and interactive passphrase authentication are preserved. Add a Windows regression test that allocates a private console and verifies the child receives both read and write access.

Validation:

  • Latest rtvision base: 31 focused tests passed across transport, editor runtime, IPC routing, and SSH runner; targeted lint, formatting, and diff checks passed.
  • The Windows-only test is skipped on Linux. Its unchanged body passed natively using Windows Node 24.19 with a temporary node:test registration adapter, and failed against the original read-only helper.
  • Complete local Windows Terminal → PowerShell → packaged Electron 44 → WSL → SSH → real Neovim flow passed with a disposable encrypted default ~/.ssh/id_ed25519, no agent, both passphrase prompts, and a saved keyboard edit.
  • The affected machine's WSL console comparison passed with the fix. Its full saved SSH environment launch after installation remains unverified.

Independent Astra review: GO, no blocking correctness findings at 4a343bc49615e440a7343c79bd1b1d14ad4e084d. The reviewer inspected the full diff and surrounding launch/test code; it did not execute tests. The Windows Vite registration and coworker's post-install saved-environment launch remain unverified. Fable was initially attempted but was unavailable due to its account usage limit; the maintainer requested Astra instead.

Implemented with GPT-6 in Codex.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XS labels Sep 10, 2026
@kalvenschraut
kalvenschraut merged commit 433ca6a into rtvision Sep 11, 2026
8 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant